Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional migrate calling #556

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conditional migrate calling #556

merged 1 commit into from
Oct 10, 2024

Conversation

kulikthebird
Copy link
Contributor

No description provided.

@kulikthebird kulikthebird self-assigned this Aug 21, 2024
@kulikthebird kulikthebird force-pushed the tkulik/conditional_migrate branch 4 times, most recently from 46f2252 to e06a7fc Compare August 22, 2024 12:50
@kulikthebird kulikthebird marked this pull request as ready for review August 26, 2024 11:07
@kulikthebird kulikthebird force-pushed the tkulik/conditional_migrate branch 9 times, most recently from 5350970 to a3b1d5c Compare August 28, 2024 12:37
@kulikthebird kulikthebird force-pushed the tkulik/conditional_migrate branch from a3b1d5c to c4f8456 Compare September 5, 2024 13:00
@kulikthebird kulikthebird added this to the 2.2.0 milestone Sep 5, 2024
@chipshort
Copy link
Collaborator

Could you update this to use a git dependency on the main branch? That way the CI can test it.

@kulikthebird kulikthebird force-pushed the tkulik/conditional_migrate branch from 1319206 to 9ac6526 Compare September 10, 2024 11:14
@kulikthebird kulikthebird force-pushed the tkulik/conditional_migrate branch from 3e51f04 to 0824c0c Compare October 9, 2024 06:51
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good to me.

@kulikthebird kulikthebird force-pushed the tkulik/conditional_migrate branch from 0824c0c to 04f4036 Compare October 9, 2024 13:55
@kulikthebird kulikthebird force-pushed the tkulik/conditional_migrate branch from 04f4036 to c9d63a4 Compare October 9, 2024 13:57
@chipshort chipshort merged commit 34db228 into main Oct 10, 2024
14 checks passed
@chipshort chipshort deleted the tkulik/conditional_migrate branch October 10, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conditional migrate call with extra MigrateInfo argument after contract update
2 participants